Fix for prepended empty bytes on KeystoreJson decrypt #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you include a demo of how you are using the decrypt functions that generated the invalid key? I use the following code and get the correct (non-prefixed) values: const json = '{"crypto":{"cipher":"aes-128-ctr","cipherparams":{"iv":"2e9dc1c889a994f29f84501a88ee28df"},"ciphertext":"9b46c206388bc115b8ac811d288c68f7ae04a7501d5ae5a67dfb230525bbfb61","kdf":"scrypt","kdfparams":{"dklen":32,"n":512,"r":8,"p":1,"salt":"4e87b121893d3082cd70212cbb4c0114e0d858e7d91092c8af3f6d599a6d2072"},"mac":"46ec1e91ec891c0fd018ec4d098036e7f41d5871278631c590349f2c094161dd"},"id":"f04398b6-d60b-4d6b-88b2-6fb9aaa69487","version":3}';
const password = "1edw8fROhOix-1QcaXQxXeoA2aCFvpHPeZxESqx-hKLHIxzVBhk8bLb8DMALuclUlbhq-arWJdMVuLM3l3uMsA==";
const pk = "0x54fc8d2c19216406f12e587253d4a52c20c6af9e1d98248381fb6133d732798f";
console.log(await ethers.decryptKeystoreJsonSync(json, password));
// {
// address: '0x18e38dA42233e0c4D6107d129A9C953800e590F3',
// privateKey: '0x54fc8d2c19216406f12e587253d4a52c20c6af9e1d98248381fb6133d732798f'
// }
(async function() {
console.log(await ethers.decryptKeystoreJson(json, password));
// {
// address: '0x18e38dA42233e0c4D6107d129A9C953800e590F3',
// privateKey: '0x54fc8d2c19216406f12e587253d4a52c20c6af9e1d98248381fb6133d732798f'
// }
})(); |
ricmoo
added
investigate
|
Sorry about that, web3dart seems to only sometimes generate a key that will fail. web3dart can always decrypt, it's ethers that can't. Here is one that will fail in ethers: Password: Error: |
|
Decryption succeeds, but there's an extra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios, decrypting a KeystoreJson can result in
00being prepended to a private key in thegetAccountfunction.Here is an example with a random key
Json:
Password:
The resulting private key should be:
But internally, the decrypt function returns:
Additional Context
This KeystoreJson and private key was generated using web3dart